Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): numfmt support i18n #1558

Merged
merged 1 commit into from
Mar 18, 2024
Merged

feat(sheet): numfmt support i18n #1558

merged 1 commit into from
Mar 18, 2024

Conversation

Gggpound
Copy link
Contributor

  • I am sure that the code is update-to-date with the dev branch.

close #

Copy link

github-actions bot commented Mar 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 32.86%. Comparing base (5aeb65f) to head (4cf3c17).

Files Patch % Lines
...src/components/more-numfmt-type/MoreNumfmtType.tsx 0.00% 1 Missing ⚠️
...sheets-numfmt/src/controllers/numfmt.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1558   +/-   ##
=======================================
  Coverage   32.86%   32.86%           
=======================================
  Files         919      919           
  Lines       51202    51204    +2     
  Branches    10661    10662    +1     
=======================================
+ Hits        16825    16827    +2     
  Misses      34377    34377           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound force-pushed the feat-nfm-support-i18n branch from 14fc864 to 4cf3c17 Compare March 12, 2024 11:31
@Gggpound Gggpound force-pushed the feat-nfm-support-i18n branch from 4cf3c17 to 02cadaa Compare March 18, 2024 09:21
@Gggpound Gggpound merged commit b39f982 into dev Mar 18, 2024
6 of 7 checks passed
@Gggpound Gggpound deleted the feat-nfm-support-i18n branch March 18, 2024 09:21
ybzky pushed a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants